Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs say that it supports a string... But is seems to support js numbers too. And people are gonna pass in JS numbers unless it's forbidden. So to avoid an accidental behavior-breaking change in the future, I figured I'd add a test.
In semver, since you documented that functions require strings, I suppose it wouldn't require a major version bump if you disallowed js numbers as inputs. In practice, that feels kinda wrong.
Note I ran the tests locally and they passed, including my new test.